Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aro-8600 deploy olm on MC #314

Merged
merged 3 commits into from
Jul 10, 2024
Merged

aro-8600 deploy olm on MC #314

merged 3 commits into from
Jul 10, 2024

Conversation

ritmun
Copy link
Collaborator

@ritmun ritmun commented Jul 5, 2024

Currently, ACM requires olm to be deployed. Installing it as step 1 for ACM install.

What this PR does

Jira: https://issues.redhat.com/browse/ARO-8600
Link to demo recording:

Special notes for your reviewer

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my questions are not blockers, I am not familiar with deploying OLM either and asking mostly out of curiosity

acm/scripts/prepare-olm.sh Outdated Show resolved Hide resolved
acm/scripts/prepare-olm.sh Outdated Show resolved Hide resolved
@mjlshen mjlshen enabled auto-merge (rebase) July 5, 2024 20:58
@ritmun ritmun changed the title aro-8600 deploy olm on MC [wip] aro-8600 deploy olm on MC Jul 5, 2024
@ritmun ritmun force-pushed the aro-8600 branch 2 times, most recently from daf92ad to cbd7fb4 Compare July 8, 2024 17:05
@ritmun
Copy link
Collaborator Author

ritmun commented Jul 8, 2024

/hold

Currently, ACM requires olm to be deployed. Installing it as step 1 for ACM install.
@ritmun ritmun requested a review from zgalor as a code owner July 9, 2024 21:49
@ritmun
Copy link
Collaborator Author

ritmun commented Jul 9, 2024

/unhold

@ritmun ritmun changed the title [wip] aro-8600 deploy olm on MC aro-8600 deploy olm on MC Jul 9, 2024
@mjlshen mjlshen disabled auto-merge July 9, 2024 23:17
@mjlshen mjlshen enabled auto-merge (squash) July 9, 2024 23:17
@mjlshen mjlshen merged commit ed2dc7e into main Jul 10, 2024
13 checks passed
@mjlshen mjlshen deleted the aro-8600 branch July 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants